[PATCH] D77424: [XCOFF][AIX] Relocation support for SymB
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 10 14:32:29 PDT 2020
jasonliu marked 3 inline comments as done.
jasonliu added inline comments.
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:400
+ const MCSectionXCOFF *ContainingCsect) {
+ // If Sym is defined, then it's a label. We need to add label's offset from
+ // its containting csect to get the correct virtual address for it.
----------------
jasonliu wrote:
> hubert.reinterpretcast wrote:
> > On the assembly path, I don't see a label for function descriptor definitions or for common definitions.
> We don't have a label for function descriptor definitions or common definitions. So those symbols won't even get here. Could you elaborate your concern?
>
Discussed offline, updated the misleading comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77424/new/
https://reviews.llvm.org/D77424
More information about the llvm-commits
mailing list