[PATCH] D77877: [llvm][NFC] Inliner.cpp: ensure InlineHistory ID is always initialized;

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.

Dealer's choice here, especially given the fact that it's just accessing/aliasing a member of the object being iterated over anyway - mostly wanted to avoid tool-based warnings maybe encouraging a style that would be systematically applied & go in not the best direction, imho.

(the fact that the value is then mutated makes it trickier for me - it's no longer the element you're iterating over, it's got state that was only established in one codepath & only usable on a matching codepath, etc... but yep, if the code had been written this new way from the start I doubt I'd have batted an eyelid/made any point that it should be written the old way just to make MSan able to find a certain set of possible bugs)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77877/new/

https://reviews.llvm.org/D77877