[PATCH] D77881: [VectorUtils] add IR-level analysis for widening of shuffle mask

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

This looks good to me, but do we want to have some roundtrip and/or exhaustive tests for this?



================
Comment at: llvm/include/llvm/Analysis/VectorUtils.h:340
 ///
-/// This is the reverse process of "canWidenShuffleElements", but can always
-/// succeed.
+/// This is the reverse process of "widenShuffleMask", but can always succeed.
 void scaleShuffleMask(size_t Scale, ArrayRef<int> Mask,
----------------
This reads weird, `can` seems out of place here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77881/new/

https://reviews.llvm.org/D77881