[PATCH] D77819: [lit] Add SKIPPED test result category

Fri Apr 10 11:33:28 PDT 2020

yln marked 2 inline comments as done.
yln added a comment.

> Can skipped tests be covered in lit's test suite?  I'm not sure how easy it is to do it in a portable manner, but platform-specific coverage is better than nothing.

Added a test for the overall lit timeout (`--max-time`) which previously didn't have one, which let's us observe the "skipped test" logic.  I am not sure how to add one for the user interrupt [Ctrl+C].

================
Comment at: llvm/utils/lit/lit/main.py:283
         return
-    if code == lit.Test.PASS:
+    # TODO(yln): FLAKYPASS? Make this more consistent!
+    if code in {lit.Test.SKIPPED, lit.Test.PASS}:
----------------
jdenny wrote:
> Does this todo mean you don't like the name SKIPPED?
No, I just noticed that handling of FLAKYPASS is missing here and I want to address it as a separate change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77819/new/

https://reviews.llvm.org/D77819