[PATCH] D77840: [mlir][drr] Allow specifying string in location

[Lei Zhang via Phabricator via llvm-commits]

antiagainst accepted this revision.
antiagainst added a comment.
This revision is now accepted and ready to land.

Cool! :)



================
Comment at: mlir/docs/DeclarativeRewrites.md:681
+*   If no symbol is specified then string must be specified and a NamedLoc is
+    created instead;
 
----------------
Update example to reflect this change?


================
Comment at: mlir/tools/mlir-tblgen/RewriterGen.cpp:688
     const auto *const lookupFmt = "(*{0}.begin()).getLoc()";
+    tree.getArgAsLeaf(idx).print(llvm::errs());
     return symbolInfoMap.getAllRangeUse(tree.getArgName(idx), lookupFmt);
----------------
Debugging leftover?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77840/new/

https://reviews.llvm.org/D77840