[PATCH] D77638: [SanitizerCoverage] Add compiler-rt test for -fsanitize-coverage=inline-bool-flag
Pratyai Mazumder via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 10 09:44:40 PDT 2020
pratyai added a comment.
In D77638#1974129 <https://reviews.llvm.org/D77638#1974129>, @fhahn wrote:
> It looks like this change breaks some macOS builds, e.g. http://green.lab.llvm.org/green/job/clang-stage1-RA/8593/
>
> I’ve disabled it for x86_64-darwin as well (it was already unsupported for i386-darwin) in d6525eff5ebfa0ef1d6cd75cb9b40b1881e7a707 <https://reviews.llvm.org/rGd6525eff5ebfa0ef1d6cd75cb9b40b1881e7a707>
>
> It would be great if you could take a look.
Sorry for the breakage; the problematic section was added in D77244 <https://reviews.llvm.org/D77244> (`SanCovBoolFlagSectionName` in `llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp`). I was wondering why the previous section name was dropping the vowels, but didn't realize that there was a character restriction.
If you think just shortening the name to something like `sancov_bools` would be sufficient, I can send a diff (, how do I test it for mac builds though?).
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77638/new/
https://reviews.llvm.org/D77638
More information about the llvm-commits
mailing list