[PATCH] D77858: [llvm-xray] Add llvm-xray extract support for 32 bit ARM

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/XRay/InstrumentationMap.cpp:133
     return make_error<StringError>(
         Twine("Instrumentation map entries not evenly divisible by size of "
+              "an XRay sled entry."),
----------------
In many command line tools, clang/lld/LLVM binary utilities/etc, a diagnostic message is not capitalized. I have noticed that llvm-xray does not follow the convention, so being consistent locally is okay.


================
Comment at: llvm/test/tools/llvm-xray/ARM/extract-instrmap-arm-mangled.test:1
+This test makes sure we can extract the instrumentation map from an
+XRay-instrumented PIE file.
----------------
You can combine the two tests, and move the content of `llvm/test/tools/llvm-xray/ARM/Inputs/elf32-pic.yaml` here.

```
## is for comments

# is for RUN and CHECK lines
# RUN: yaml2obj %s -o %t
```

`llvm/test/tools/llvm-xray/ARM/Inputs/elf32-pic.yaml` is too large. This is not okay. It should be reduced to the minimum.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77858/new/

https://reviews.llvm.org/D77858