[PATCH] D77818: [lit] Print substitutions with --show-suites
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 10 08:28:50 PDT 2020
jdenny accepted this revision.
jdenny added a comment.
Other than the comment I added, LGTM. Thanks.
================
Comment at: llvm/utils/lit/lit/main.py:140
print(' Exec Root : %s' % suite.exec_root)
if suite.config.available_features:
features = ' '.join(sorted(suite.config.available_features))
----------------
yln wrote:
> Let's change this to always print `available_features` and `substitutions`. Not having any is rare and that is information as well.
Please mention the change for `available_features` in the patch summary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77818/new/
https://reviews.llvm.org/D77818
More information about the llvm-commits
mailing list