[PATCH] D77870: [MLIR] Introduce utility to hoist affine if/else conditions
Andy Davis via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 10 08:27:42 PDT 2020
andydavis1 added inline comments.
================
Comment at: mlir/lib/Dialect/Affine/Utils/Utils.cpp:67
+// Returns true if the hoisting happened or if the op was folded away.
+bool mlir::hoistAffineIfOp(AffineIfOp ifOp, bool *folded) {
+ // Apply canonicalization patterns and folding - this is necessary for the
----------------
This function is well documented but a little long. Could it be broken up a bit? For example, the canonicalization bit a the top of the function could be pulled out into a separate function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77870/new/
https://reviews.llvm.org/D77870
More information about the llvm-commits
mailing list