[PATCH] D77819: [lit] Add SKIPPED test result category

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

Thanks for doing this.  I like the idea of the change.

Can skipped tests be covered in lit's test suite?  I'm not sure how easy it is to do it in a portable manner, but platform-specific coverage is better than nothing.



================
Comment at: llvm/utils/lit/lit/main.py:283
         return
-    if code == lit.Test.PASS:
+    # TODO(yln): FLAKYPASS? Make this more consistent!
+    if code in {lit.Test.SKIPPED, lit.Test.PASS}:
----------------
Does this todo mean you don't like the name SKIPPED?


================
Comment at: llvm/utils/lit/lit/main.py:284
-       (lit.Test.UNSUPPORTED == code and not opts.show_unsupported) or \
-       (lit.Test.UNRESOLVED == code and (opts.max_failures is not None)):
         return
----------------
There's a change in the effect of `opts.max_failures` on both skipped tests and the remaining unresolved tests.

It seems like that should be mentioned in the patch summary.

Can at least the latter change be covered in lit's test suite?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77819/new/

https://reviews.llvm.org/D77819