[PATCH] D77067: [mlir][Linalg] Create a tool to generate named Linalg ops from a Tensor Comprehensions-like specification.

[Alex Zinenko via Phabricator via llvm-commits]

ftynse accepted this revision.
ftynse added a comment.

Please fix the Windows build problem before landing. It looks like the pre-merge testing has such build now so you can use it for the initial check.



================
Comment at: mlir/docs/Dialects/Linalg.md:473
+    resorting to more general MLIR parsing.
+1.  Reduction dimensions are specified with bracket notation on the operation
+    they apply to (e.g. `std_add<k>` specifies that `k` is a reduction
----------------
Nit: angle bracket notation


================
Comment at: mlir/test/mlir-linalg-ods-gen/test-linalg-ods-gen.tc:5
+// RUN: mlir-linalg-ods-gen %s -gen-ods-decl=1 -o %t-ods.td \
+// RUN: && echo 'include "mlir/Dialect/Linalg/IR/LinalgStructuredOps.td" ' $(cat %t-ods.td) \
+// RUN: | mlir-tblgen -gen-op-decls -I %S/../../include
----------------
This won't work on Windows. Consider adding a `-test-emit-additional-includes` flag to `mlir-linalg-ods-gen` and use it here instead of trying shell magic.


================
Comment at: mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp:822
+                                                 /*allowEmptyList=*/true)))
+    assert(false);
+
----------------
llvm_unreachable ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77067/new/

https://reviews.llvm.org/D77067