[PATCH] D77841: [RISCV] Consume error from parsing attributes section
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 10 07:24:16 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG49e20c4c9efe: [RISCV] Consume error from parsing attributes section (authored by jrtc27).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77841/new/
https://reviews.llvm.org/D77841
Files:
llvm/lib/Object/ELFObjectFile.cpp
Index: llvm/lib/Object/ELFObjectFile.cpp
===================================================================
--- llvm/lib/Object/ELFObjectFile.cpp
+++ llvm/lib/Object/ELFObjectFile.cpp
@@ -297,8 +297,11 @@
// Add features according to the ELF attribute section.
// If there are any unrecognized features, ignore them.
RISCVAttributeParser Attributes;
- if (Error E = getBuildAttributes(Attributes))
+ if (Error E = getBuildAttributes(Attributes)) {
+ // TODO Propagate Error.
+ consumeError(std::move(E));
return Features; // Keep "c" feature if there is one in PlatformFlags.
+ }
Optional<StringRef> Attr = Attributes.getAttributeString(RISCVAttrs::ARCH);
if (Attr.hasValue()) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77841.256570.patch
Type: text/x-patch
Size: 711 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200410/f9c72fef/attachment.bin>
More information about the llvm-commits
mailing list