[compiler-rt] 87735b5 - tsan: don't check libc dependency on NetBSD

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 10 02:13:18 PDT 2020


Author: Dmitry Vyukov
Date: 2020-04-10T11:12:55+02:00
New Revision: 87735b5b1d03783fb5276c076578f65af20125e2

URL: https://github.com/llvm/llvm-project/commit/87735b5b1d03783fb5276c076578f65af20125e2
DIFF: https://github.com/llvm/llvm-project/commit/87735b5b1d03783fb5276c076578f65af20125e2.diff

LOG: tsan: don't check libc dependency on NetBSD

This new check fails on NetBSD as well.
It is meant to prevent regressions, so disable it on NetBSD.

Reported-by: Keith Randall (khr)

Added: 
    

Modified: 
    compiler-rt/lib/tsan/go/buildgo.sh

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/tsan/go/buildgo.sh b/compiler-rt/lib/tsan/go/buildgo.sh
index 6133421318f2..7cdb6f0a7f7b 100755
--- a/compiler-rt/lib/tsan/go/buildgo.sh
+++ b/compiler-rt/lib/tsan/go/buildgo.sh
@@ -87,6 +87,10 @@ elif [ "`uname -a | grep FreeBSD`" != "" ]; then
 		../../sanitizer_common/sanitizer_stoptheworld_netbsd_libcdep.cpp
 	"
 elif [ "`uname -a | grep NetBSD`" != "" ]; then
+	# The resulting object still depends on libc.
+	# We removed this dependency for Go runtime for other OSes,
+	# and we should remove it for NetBSD as well, but there is no pressing need.
+	DEPENDS_ON_LIBC=1
 	SUFFIX="netbsd_amd64"
 	OSCFLAGS="-fno-strict-aliasing -fPIC -Werror"
 	ARCHCFLAGS="-m64"


        


More information about the llvm-commits mailing list