[PATCH] D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC

Fri Apr 10 01:35:48 PDT 2020

tambre abandoned this revision.
tambre added a comment.

In D77370#1972378 <https://reviews.llvm.org/D77370#1972378>, @ldionne wrote:

> In D77370#1970102 <https://reviews.llvm.org/D77370#1970102>, @compnerd wrote:
>
> > [...]
> >  Actually, if we want to do that, I think that we should redo the build to remove `LIBUNWIND_ENABLE_SHARED`/`LIBUNWIND_ENABLE_STATIC` - they are supposed to be specified by the user as `BUILD_SHARED_LIBS=[YES|NO]` not as a single build as it is currently.  But, that is beyond the scope of this change and more about the philosophical approach that you are suggesting here.
>
>
> I agree with that in principle, and it has been a source of frustration/confusion about how we build things in the runtimes.
>
> So, @tambre, is there anything that makes specifying `CMAKE_POSITION_INDEPENDENT_CODE=ON` in your cache not a viable option? Would it work? Would it introduce other complexity or weirdness into your build? I'm trying to weigh the options we have here.

I've tested it out now and `CMAKE_POSITION_INDEPENDENT_CODE=ON` suffices.
Thanks for reviewing and all the info.

It seems this same way should work for libc++abi.
Would it make sense to remove `LIBCXXABI_ENABLE_PIC` for consistency?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77370/new/

https://reviews.llvm.org/D77370