[PATCH] D77359: [libunwind] add hexagon support

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 22:17:55 PDT 2020


mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

Looks good to me now



================
Comment at: libunwind/src/Registers.hpp:3556
+  void      setSP(uint32_t value) { _registers.__r[UNW_HEXAGON_R29] = value; }
+  //uint32_t  getIP() const         { return (uint32_t)__builtin_return_address(0) - 4; }
+  uint32_t  getIP() const         { return _registers.__r[UNW_HEXAGON_PC]; }
----------------
This looks like a leftover


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77359/new/

https://reviews.llvm.org/D77359





More information about the llvm-commits mailing list