[PATCH] D77852: Outline CFI Instructions in Tail Calls

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-cfi-tail.mir:4-6
+# Outlining CFI instructions is unsafe if it is not tail called, but otherwise,
+# it requires fixups. Show that we don't include CFI instructions in non
+# tail call outlined sequences right now.
----------------
Is this comment accurate? This test is to show that we do outline CFI instructions in tail calls, right?


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-cfi.mir:6
+# it requires fixups. Show that we don't include CFI instructions in non
+# tail call outlined sequences right now.
 
----------------
AndrewLitteken wrote:
> paquette wrote:
> > This testcase is the same as the new one you're adding, right?
> > 
> > I don't think we need both testcases if so. I think it would be better to just keep this one and not add a new, identical test.
> This is the old test so that it actually shows this.  The previous test could outline the CFI instruction, this one should not.  The comments are the same because I was copy pasting the file to get the testing framework correct.
Ah now I see!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77852/new/

https://reviews.llvm.org/D77852