[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 21:25:05 PDT 2020


mehdi_amini added a comment.

But this sentence alone at the end of this paragraph does not solve anything to me: how is one know that someone in an "area" (whatever that means) is expected to review all the "non-trivial" patches pre-commit?

I don't necessarily disagree with your underlying intent, I just feel that adding this sentence here won't help and does not fit in an existing "process".

And you're adding this after "If there is likely to be uncertainty, you should default to getting a patch reviewed prior to commit", I don't see why the addition is useful here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77683/new/

https://reviews.llvm.org/D77683





More information about the llvm-commits mailing list