[PATCH] D77424: [XCOFF][AIX] Relocation support for SymB

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:400
+                                     const MCSectionXCOFF *ContainingCsect) {
+    // If Sym is defined, then it's a label. We need to add label's offset from
+    // its containting csect to get the correct virtual address for it.
----------------
On the assembly path, I don't see a label for function descriptor definitions or for common definitions.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:401
+    // If Sym is defined, then it's a label. We need to add label's offset from
+    // its containting csect to get the correct virtual address for it.
+    return SectionMap[ContainingCsect]->Address +
----------------
Typo: s/containting/containing/;


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:406
+
+  const MCSymbol *SymA = &Target.getSymA()->getSymbol();
 
----------------
If this is not being changed, then—given the size of the function—using `const MCSymbol *const SymA` could help readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77424/new/

https://reviews.llvm.org/D77424