[PATCH] D71443: [MC][PowerPC] Fix a crash when redefining a symbol after .set

Thu Apr 9 20:53:00 PDT 2020

nemanjai added a comment.

@MaskRay @luporl Is it possible for `Sym` to be `null` here? Do we need a `nullptr` check? I ask because we seem to have a crash here reported in https://bugs.llvm.org/show_bug.cgi?id=45366 that we cannot reproduce. But I wonder if perhaps this might be the issue.

I have asked the OP of the PR to try the patch that adds the null check, but I was hoping to get your opinion on this as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71443/new/

https://reviews.llvm.org/D71443