[PATCH] D77853: [AArch64InstPrinter] Change printAlignedLabel to print the target address in hexadecimal form

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 20:08:25 PDT 2020


MaskRay created this revision.
Herald added subscribers: llvm-commits, rupprecht, hiraditya, kristof.beyls, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.

Similar to D76580 <https://reviews.llvm.org/D76580> (x86) and D76591 <https://reviews.llvm.org/D76591> (PPC).

  // llvm-objdump -d output (before)
  10000: 08 00 00 94                   bl      #32
  10004: 08 00 00 94                   bl      #32
  
  // llvm-objdump -d output (after)
  10000: 08 00 00 94                   bl      0x10020
  10004: 08 00 00 94                   bl      0x10024
  
  // GNU objdump -d. The lack of 0x is not ideal due to ambiguity.
  10000:       94000008        bl      10020 <bar+0x18>
  10004:       94000008        bl      10024 <bar+0x1c>

The new output akes it easier to find the jump target.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77853

Files:
  lld/test/COFF/arm64-delayimport.yaml
  lld/test/COFF/arm64-import2.test
  lld/test/COFF/arm64-relocs-imports.test
  lld/test/COFF/arm64-thunks.s
  lld/test/ELF/aarch64-call26-thunk.s
  lld/test/ELF/aarch64-condb-reloc.s
  lld/test/ELF/aarch64-cortex-a53-843419-address.s
  lld/test/ELF/aarch64-cortex-a53-843419-large.s
  lld/test/ELF/aarch64-cortex-a53-843419-large2.s
  lld/test/ELF/aarch64-cortex-a53-843419-recognize.s
  lld/test/ELF/aarch64-cortex-a53-843419-thunk.s
  lld/test/ELF/aarch64-feature-bti.s
  lld/test/ELF/aarch64-feature-btipac.s
  lld/test/ELF/aarch64-feature-pac.s
  lld/test/ELF/aarch64-gnu-ifunc-plt.s
  lld/test/ELF/aarch64-gnu-ifunc.s
  lld/test/ELF/aarch64-jump26-thunk.s
  lld/test/ELF/aarch64-plt.s
  lld/test/ELF/aarch64-relocs.s
  lld/test/ELF/aarch64-thunk-pi.s
  lld/test/ELF/aarch64-thunk-script.s
  lld/test/ELF/aarch64-thunk-section-location.s
  lld/test/ELF/aarch64-tstbr14-reloc.s
  lld/test/ELF/aarch64-undefined-weak.s
  lld/test/ELF/pr34660.s
  lld/test/ELF/relocation-b-aarch64.test
  llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
  llvm/test/CodeGen/AArch64/callbr-asm-obj-file.ll
  llvm/test/CodeGen/AArch64/inlineasm-ldr-pseudo.ll
  llvm/test/tools/llvm-objdump/MachO/AArch64/pc-rel-targets.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77853.256490.patch
Type: text/x-patch
Size: 52014 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200410/b747e047/attachment.bin>


More information about the llvm-commits mailing list