[PATCH] D77027: Make BitVector::operator== return false for different-sized vectors
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 9 18:32:03 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG27f1895f53d4: Make BitVector::operator== return false for different-sized vectors. (authored by bmoody, committed by Meinersbur).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77027/new/
https://reviews.llvm.org/D77027
Files:
llvm/include/llvm/ADT/BitVector.h
llvm/unittests/ADT/BitVectorTest.cpp
Index: llvm/unittests/ADT/BitVectorTest.cpp
===================================================================
--- llvm/unittests/ADT/BitVectorTest.cpp
+++ llvm/unittests/ADT/BitVectorTest.cpp
@@ -179,6 +179,24 @@
EXPECT_TRUE(Vec.empty());
}
+TYPED_TEST(BitVectorTest, Equality) {
+ TypeParam A;
+ TypeParam B;
+ EXPECT_TRUE(A == B);
+ A.resize(10);
+ EXPECT_FALSE(A == B);
+ B.resize(10);
+ EXPECT_TRUE(A == B);
+ A.set(5);
+ EXPECT_FALSE(A == B);
+ B.set(5);
+ EXPECT_TRUE(A == B);
+ A.resize(20);
+ EXPECT_FALSE(A == B);
+ B.resize(20);
+ EXPECT_TRUE(A == B);
+}
+
TYPED_TEST(BitVectorTest, SimpleFindOpsMultiWord) {
TypeParam A;
Index: llvm/include/llvm/ADT/BitVector.h
===================================================================
--- llvm/include/llvm/ADT/BitVector.h
+++ llvm/include/llvm/ADT/BitVector.h
@@ -532,24 +532,10 @@
// Comparison operators.
bool operator==(const BitVector &RHS) const {
- unsigned ThisWords = NumBitWords(size());
- unsigned RHSWords = NumBitWords(RHS.size());
- unsigned i;
- for (i = 0; i != std::min(ThisWords, RHSWords); ++i)
- if (Bits[i] != RHS.Bits[i])
- return false;
-
- // Verify that any extra words are all zeros.
- if (i != ThisWords) {
- for (; i != ThisWords; ++i)
- if (Bits[i])
- return false;
- } else if (i != RHSWords) {
- for (; i != RHSWords; ++i)
- if (RHS.Bits[i])
- return false;
- }
- return true;
+ if (size() != RHS.size())
+ return false;
+ unsigned NumWords = NumBitWords(size());
+ return Bits.take_front(NumWords) == RHS.Bits.take_front(NumWords);
}
bool operator!=(const BitVector &RHS) const {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77027.256469.patch
Type: text/x-patch
Size: 1709 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200410/4d94e72e/attachment.bin>
More information about the llvm-commits
mailing list