[PATCH] D77786: [AArch64] Add v8.5 Branch Target Identification support.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 9 17:27:23 PDT 2020
MaskRay added inline comments.
================
Comment at: libunwind/src/assembly.h:46
.Lfunc_begin0:
+#elif (defined(__arm64__) || defined(__aarch64__)) && defined(__ARM_FEATURE_BTI_DEFAULT)
+#define PPC64_OPD1 \
----------------
Just use `defined(__aarch64__)`. I deleted `__arm64__` in D77829
================
Comment at: libunwind/src/assembly.h:48
+#define PPC64_OPD1 \
+ .pushsection ".note.gnu.property", "a" SEPARATOR \
+ .balign 8 SEPARATOR \
----------------
I am worried that we may want to change the section type for .note.gnu.property
https://sourceware.org/pipermail/binutils/2020-April/000372.html
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77786/new/
https://reviews.llvm.org/D77786
More information about the llvm-commits
mailing list