[PATCH] D76252: [lld-macho] Add basic support for linking against dylibs

[Jez Ng via Phabricator via llvm-commits]

int3 marked 2 inline comments as done.
int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:225
+  // Initialize symbols.
+  if (const load_command *cmd = findCommand(hdr, LC_SYMTAB)) {
+    auto *c = (const symtab_command *)cmd;
----------------
smeenai wrote:
> Is it correct to just consider LC_SYMTAB for this, or should we also be consulting LC_DYSYMTAB and/or the export trie? If so, we don't have to address that in this diff, but we should add a TODO.
> 
> We should also add a TODO about handling a missing LC_SYMTAB.
I *think* the export trie is only consumed by dyld. Let me see what the deal is with LC_DYSYMTAB...


================
Comment at: lld/MachO/InputFiles.h:37
 
+  StringRef path;
   MemoryBufferRef mb;
----------------
smeenai wrote:
> Where is this used?
`error("dylib " + path + " missing LC_ID_DYLIB load command");` in InputFiles.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76252/new/

https://reviews.llvm.org/D76252