[PATCH] D77741: [FileCheck] Better diagnostic for format conflict

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 17:26:09 PDT 2020


jdenny added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:39
+  default:
+    llvm_unreachable("unknown expression format");
+  }
----------------
One more thing: clang-tidy is saying you're violating this:

http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77741/new/

https://reviews.llvm.org/D77741





More information about the llvm-commits mailing list