[PATCH] D77607: [FileCheck] Fix --dump-input annotation sort per input line

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D77607#1971405 <https://reviews.llvm.org/D77607#1971405>, @thopre wrote:

> In D77607#1970773 <https://reviews.llvm.org/D77607#1970773>, @jdenny wrote:
>
> > (By the way, some time ago I started developing patches to show variable captures as annotations on input lines.  I've found that really helpful when debugging.  They need more work, such as adding support for numeric variables.  I'll try to get those into phabricator soon.)
>
>
> So you mean it show the value when it's captured as opposed to when it's used like what -vv shows? Or is there more to it?


As you say, substitutions/uses are printed already as diagnostics.  One of my patches adds them to `-dump-input` annotations, where I find them to be useful too.

Another patch adds the definitions/captures both to the diagnostics and to `-dump-input` annotations.

(Of course, verbose diagnostics are suppressed when `-dump-input` is specified, so you won't get tons of this stuff twice.)

Finally, upon a failed match, another patch lists variables that the pattern is intended to capture.  Someone pointed out once that, if you write a capturing expression without meaning to because the syntax of the language you're matching happens to look like FileCheck capturing syntax, it can be very confusing when the match fails.  This patch should help.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77607/new/

https://reviews.llvm.org/D77607