[PATCH] D77832: Allow single-bit integer types to have signs.  A signed one bit integer is either 0 or -1.
    Chris Lattner via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Apr  9 15:30:17 PDT 2020
    
    
  
lattner marked 2 inline comments as done.
lattner added inline comments.
================
Comment at: mlir/test/IR/attribute.mlir:84
+    // CHECK-SAME: attr_20 = 1 : ui1
+    attr_20 = 1: ui1,
+    // CHECK-SAME: attr_21 = -1 : si1
----------------
rriddle wrote:
> nit: 1 : ui1 
> 
> to match the output
Sorry I didn't see this comment (still relatively new to phabricator).  I'll push a follow up commit with this tweak.  Thank you for the review!
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77832/new/
https://reviews.llvm.org/D77832
    
    
More information about the llvm-commits
mailing list