[PATCH] D77638: [SanitizerCoverage] Add compiler-rt test for -fsanitize-coverage=inline-bool-flag

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 13:51:02 PDT 2020


vitalybuka added a comment.

Yes, please.

In D77638#1971544 <https://reviews.llvm.org/D77638#1971544>, @pratyai wrote:

> In D77638#1971542 <https://reviews.llvm.org/D77638#1971542>, @vitalybuka wrote:
>
> > I'll submit this a little bit later
>
>
> I realized only now that I didn't update a few  files in compiler-rt that provides weak, empty implementations:
>
> - https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_interface_internal.h
> - https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_coverage_interface.inc
> - https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_coverage_libcdep_new.cpp
> - https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/fuzzer/FuzzerTracePC.cpp
>
>   (the last one was the reason of the fuzzer failure on the previous diff I guess)
>
>   Should I add them in this diff (/ another diff / not necessary)?





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77638/new/

https://reviews.llvm.org/D77638





More information about the llvm-commits mailing list