[PATCH] D77353: [WebAssembly] Add DW_OP_WASM_location_int
Wouter van Oortmerssen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 9 13:21:12 PDT 2020
aardappel added a comment.
@yurydelendik how would you change ` Descriptions[DW_OP_WASM_location] = Desc(Op::Dwarf4, Op::SizeLEB, Op::SignedSizeLEB);` to make it variadic? And there may be further locations that need to support this.
We didn't "solve" plumbing, we circumvented it for the moment :)
When a location is a local, it is still being output with your existing LEB code. So we could make your suggestion happen simply by using `DW_OP_WASM_location` instead of `DW_OP_WASM_location_int`.
@dschuff Yes, I could bake the cases of the `wasm::TI_` enum into multiple `DW_OP_WASM_` tags, be happy to do that as part of this patch. We could then deprecate the existing `DW_OP_WASM_location` tag. Consumers already need to deal with new tags showing up for globals, might as well do it for locals at the same time then?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77353/new/
https://reviews.llvm.org/D77353
More information about the llvm-commits
mailing list