[PATCH] D77795: [GlobalISel] translate freeze to COPY

Dominik Montada via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 12:54:43 PDT 2020


gargaroff added a comment.

In D77795#1972304 <https://reviews.llvm.org/D77795#1972304>, @arsenm wrote:

> In D77795#1972303 <https://reviews.llvm.org/D77795#1972303>, @gargaroff wrote:
>
> > In D77795#1972248 <https://reviews.llvm.org/D77795#1972248>, @arsenm wrote:
> >
> > > The copy won't be legalized, so you're going to have issues emitting a copy for any non-legal source. We need a legalizable G_FREEZE
> >
> >
> > How should legalization rules look like? Since the value has to be stable I'm guessing zero extend for widen and unmerge/merge/extract/insert for narrow?
>
>
> The same as whatever SelectionDAG does? It has the full set of legalize handling


Oh, right. Seems like I was totally getting ahead of myself 😅

Anyway. I'll try to come up with something tomorrow or over the weekend. Maybe just for scalars as a first step. If vectors turn out to not be too complex either, I'll try to add them as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77795/new/

https://reviews.llvm.org/D77795





More information about the llvm-commits mailing list