[PATCH] D77027: Make BitVector::operator== return false for different-sized vectors

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a subscriber: lattner.
dblaikie added a comment.
This revision is now accepted and ready to land.

In D77027#1969672 <https://reviews.llvm.org/D77027#1969672>, @Meinersbur wrote:

> Also note, that the implementation of BitVector's hash value is:
>
>   static unsigned getHashValue(const BitVector &V) {
>     return DenseMapInfo<std::pair<unsigned, ArrayRef<uintptr_t>>>::getHashValue(
>         std::make_pair(V.size(), V.getData()));
>   }
>   
>
> that is the current implementation may have different hashes for 'equal' BitVectors.


Good point!

Yeah, combination of factors makes me feel like this is the best direction. (@lattner in case he has some deep memories of this place - but happy to let that be post-commit review given the current state of BitVector and its usage)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77027/new/

https://reviews.llvm.org/D77027