[PATCH] D76624: [MSan] Add instrumentation for SystemZ

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 12:29:15 PDT 2020


eugenis marked an inline comment as done.
eugenis added a comment.

LGTM



================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:397
+static const MemoryMapParams Linux_S390X_MemoryMapParams = {
+    0xC00000000000, // AndMask
+    0,              // XorMask (not used)
----------------
iii wrote:
> eugenis wrote:
> > wrong indent here and below
> I tried changing this, but the result doesn't pass arcanist linter. Apparently it thinks that the existing indentation is wrong.
Ha, you (and arcanist) are correct, this is actually the right indentation.
I don't want to reformat the entire file at once because it would mess with the history.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76624/new/

https://reviews.llvm.org/D76624





More information about the llvm-commits mailing list