[PATCH] D77703: [mlir][Vector] Add lowering of 1-D vector transfer_read/write to masked load/store

[Aart Bik via Phabricator via llvm-commits]

aartbik accepted this revision.
aartbik added inline comments.
Herald added a subscriber: frgossen.


================
Comment at: mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp:788
+  assert(succeeded(successStrides) && "unexpected non-strided memref");
+  (void)successStrides;
+  return getStridedElementPtr(loc, ptrType, memRefDesc, indices, strides,
----------------
this was of course already there before you moved, but it just caught my eye

I am guessing we are doing this to avoid compiler errors in non-debug mode (successStrides not used) . Are there any plans to make the compiler smarter about uses in asserts? It seems a bit strange to add code like this just to suppress those?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77703/new/

https://reviews.llvm.org/D77703