[PATCH] D77485: [MLIR] Handle in-place folding properly in greedy pattern rewrite driver

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 11:02:48 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp:191
       // Try to fold this op.
-      if (succeeded(folder.tryToFold(op, collectOps, preReplaceAction))) {
+      bool inPlaceUpdate;
+      if ((succeeded(folder.tryToFold(op, collectOps, preReplaceAction,
----------------
We could just set this inside of preReplaceAction instead of changing the folder API for now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77485/new/

https://reviews.llvm.org/D77485





More information about the llvm-commits mailing list