[PATCH] D77785: Use FrameIndexTy for stack protector

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

In D77785#1972276 <https://reviews.llvm.org/D77785#1972276>, @arsenm wrote:

> This is really a workaround. The stacksave intrinsic should have the same address space as the alloca address space


I'm not sure the canary value needs to be the same type as an alloca address space pointer, I could also imagine people wanting to store a code pointer or an arbitrary integer instead?
In any case, the pointer to load the value is definitely a FrameIndexTy so I think this is the correct regardless of whether the stackguard/stackprotector intrinsics are changed to use llvm_anyptrptr_ty.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77785/new/

https://reviews.llvm.org/D77785