[PATCH] D77567: [RISCV] Implement evaluateBranch

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 05:55:47 PDT 2020


asb accepted this revision.
asb added a comment.

Thanks Simon, LGTM. I noted a tiny nit re the test file.



================
Comment at: llvm/test/MC/Disassembler/RISCV/branch-targets.txt:1
+# RUN: llvm-mc -assemble -triple riscv32 -mattr=+c -filetype=obj %s -o - 2>&1 | \
+# RUN:   llvm-objdump -d --mattr=+c -M no-aliases - | FileCheck %s
----------------
Even though it's fairly redundant, we tend to err on the side of testing both rv32 and rv64 at the same time. It would be nice to do so here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77567/new/

https://reviews.llvm.org/D77567





More information about the llvm-commits mailing list