[PATCH] D77739: [InstCombine] replace undef in vector constant for safe shift transform (PR45447)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 05:23:28 PDT 2020


spatel added a comment.

In D77739#1970300 <https://reviews.llvm.org/D77739#1970300>, @lebedev.ri wrote:

> I suspect there are other cases like this (where we used `getSafeVectorConstantForBinop()`).


I did a quick check of the remaining (3) uses, and they look ok to me. Those are shuffle+binop transforms and are not gated by a constraint on the constant values (other than we don't want to create extra UB/poison via re-ordering).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77739/new/

https://reviews.llvm.org/D77739





More information about the llvm-commits mailing list