[PATCH] D77716: [obj2yaml] - Do not dump the segment's "Align" field when it is equal to 1.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 04:18:28 PDT 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:322
+    // yaml2obj sets the alignment of a segment to 1 by default.
+    // We do not print the default alignment to reduce noise in the output.
+    if (Phdr.p_align != 1)
----------------
MaskRay wrote:
> 
> 
> Omit it to reduce output?
I'd keep the current version: as we already have the another comment in this file saying almost the same: "Generally we are trying to reduce noise in the YAML output.". (I am not sure that "reducing the output" is better describes our goal, we want to omit unnessesary parts, it is very close and reduces the output, but is not 100% the same probably.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77716/new/

https://reviews.llvm.org/D77716





More information about the llvm-commits mailing list