[PATCH] D77636: [LV] Assert no DbgInfoIntrinsic calls are passed to widening (NFC).
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 9 03:46:16 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa7efe06af0f5: [LV] Assert no DbgInfoIntrinsic calls are passed to widening (NFC). (authored by fhahn).
Changed prior to commit:
https://reviews.llvm.org/D77636?vs=255630&id=256236#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77636/new/
https://reviews.llvm.org/D77636
Files:
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
Index: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
===================================================================
--- llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
+++ llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
@@ -4362,11 +4362,8 @@
void InnerLoopVectorizer::widenCallInstruction(CallInst &I, VPUser &ArgOperands,
VPTransformState &State) {
- // Ignore dbg intrinsics.
- // TODO: Debug intrinsics should be skipped/handled during VPlan construction
- // rather than dropping them here.
- if (isa<DbgInfoIntrinsic>(I))
- return;
+ assert(!isa<DbgInfoIntrinsic>(I) &&
+ "DbgInfoIntrinsic should have been dropped during VPlan construction");
setDebugLocFromInst(Builder, &I);
Module *M = I.getParent()->getParent()->getParent();
@@ -7247,6 +7244,7 @@
Builder.setInsertPoint(VPBB);
// Introduce each ingredient into VPlan.
+ // TODO: Model and preserve debug instrinsics in VPlan.
for (Instruction &I : BB->instructionsWithoutDebug()) {
Instruction *Instr = &I;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77636.256236.patch
Type: text/x-patch
Size: 1080 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200409/bbad5d5f/attachment.bin>
More information about the llvm-commits
mailing list