[PATCH] D77289: [Object] Fix crash caused by unhandled error.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 9 03:45:59 PDT 2020
grimar added a comment.
In D77289#1971375 <https://reviews.llvm.org/D77289#1971375>, @jhenderson wrote:
> However, I think it may deserve pulling into a separate change from the new error check. That would make it an NFC interface change.
+1.
> As for the other code paths I've highlighted, it's probably okay to just put a TODO saying "needs testing" or something to that effect for most of them. @grimar, what do you think?
I agree. It might be hard/take time to add test cases for all places, but it should not be a stopper for us I believe.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77289/new/
https://reviews.llvm.org/D77289
More information about the llvm-commits
mailing list