[PATCH] D76767: [RISCV] Support negative constants in CompressInstEmitter

Simon Cook via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 02:08:35 PDT 2020


simoncook added a comment.

In D76767#1970892 <https://reviews.llvm.org/D76767#1970892>, @apazos wrote:

> To clarify, we were not missing in compressed instructions before, this change is for the future compressed instructions to be added, confirmed? Otherwise I need to check why we missed it with the fuzzer.


Yes, this only became a thing because one of the bitmanip proposed/wishlist compressed instructions wants to match against -1, all the currently ratified instructions either match immediate 0 or greater, so this wouldn't have come up before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76767/new/

https://reviews.llvm.org/D76767





More information about the llvm-commits mailing list