[PATCH] D77780: Remove -implicit-check-not=foo from X86/disassemble-functions.test

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 01:03:45 PDT 2020


Higuoxing added a comment.

I guess we want to test dumping different symbols here. If we specify `--disassemble-symbols=main`, we don't want `llvm-objdump` to dump the content of `foo` here. So, we should ensure `llvm-objdump` will not print `foo`. At least, I think we should not remove `--implicit-check-not="<foo>:"`, but improve the robustness of checking?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77780/new/

https://reviews.llvm.org/D77780





More information about the llvm-commits mailing list