[PATCH] D77638: [part 3] sancov/inline-bool-flag compiler-rt test.

Wed Apr 8 22:40:06 PDT 2020

pratyai marked an inline comment as done.
pratyai added inline comments.

================
Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_inline_bool_flag.cpp:4
+// REQUIRES: has_sancovcc,stable-runtime
+// UNSUPPORTED: i386-darwin
+//
----------------
vitalybuka wrote:
> can you add comment why it's unsupported here, and XFAIL tsan
This is something I just copied from https://reviews.llvm.org/source/llvm-github/browse/master/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_inline8bit_counter.cpp, but cannot find a reference why exactly darwin and tsan are problem.

I can see that trying to instrument both thread and coverage emits a warning about just ignoring the latter (a.cc is just some helloworld code).
/tmp $ clang++ -g a.cc -fsanitize=thread -fsanitize-coverage=trace-pc-guard
clang: warning: argument unused during compilation: '-fsanitize-coverage=trace-pc-guard' [-Wunused-command-line-argument]

The i38c-darwin was there from the version#0 of that^ file. Although originally it had more entries, some of which got removed in https://reviews.llvm.org/rGdd862f9106199ce2dd04ebc93e9bfd203465c1ee.

Not really sure what to comment beside `// Kept same as 'sanitizer_coverage_inline8bit_counter.cpp'`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77638/new/

https://reviews.llvm.org/D77638