[PATCH] D77637: [part 2] sancov/inline-bool-flag clang flags.

Wed Apr 8 21:35:01 PDT 2020

pratyai marked 2 inline comments as done.
pratyai added inline comments.

================
Comment at: clang/test/Driver/fsanitize-coverage.c:114
+// RUN: %clang -target x86_64-linux-gnu -fsanitize-coverage=inline-8bit-counters,pc-table %s -### 2>&1 | FileCheck %s --check-prefix=CHECK_PC_TABLE_FOR_INLINE8BIT
+// RUN: %clang -target x86_64-linux-gnu -fsanitize-coverage=trace-pc-guard,pc-table %s -### 2>&1 | FileCheck %s --check-prefix=CHECK_PC_TABLE_FOR_INLINE8BIT
+// CHECK_PC_TABLE_FOR_INLINE8BIT: -fsanitize-coverage-pc-table
----------------
vitalybuka wrote:
> this is preexisted block, could you make sure it's outside of your changes? move up or down
> or it looks like you replaced these lines
Moved the block up.

There is a slight change in the name s/CHECK_PC_TABLE/CHECK_PC_TABLE_FOR_INLINE8BIT/ to make it a counterpart of CHECK_PC_TABLE_FOR_INLINEBOOL.

The change isn't strictly necessary. Let me know if it should be dropped.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77637/new/

https://reviews.llvm.org/D77637