[PATCH] D77768: [mlir] Refactor ClassID into a more robust TypeID class.

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added a comment.

Seems like a big change.  I don't know if it's worthwhile breaking it down first (like const ClassID * -> TypeID, as a separate change).   Might be hard to get the const correctness right, I guess.



================
Comment at: mlir/include/mlir/IR/Location.h:280
+  /// Returns a TypeID that represents the underlying objects c++ type.
+  TypeID getClassID() const;
 
----------------
getTypeID()?


================
Comment at: mlir/lib/Dialect/Affine/Transforms/AffineLoopInvariantCodeMotion.cpp:44-45
 ///       uses.
-struct LoopInvariantCodeMotion
-    : public AffineLoopInvariantCodeMotionBase<LoopInvariantCodeMotion> {
+struct AffineLoopInvariantCodeMotion
+    : public AffineLoopInvariantCodeMotionBase<AffineLoopInvariantCodeMotion> {
   void runOnFunction() override;
----------------
rename seems unrelated?


================
Comment at: mlir/lib/IR/Location.cpp:133
 
-ClassID *OpaqueLoc::getClassId() const { return getImpl()->classId; }
+TypeID OpaqueLoc::getClassID() const { return getImpl()->typeID; }
 
----------------
maybe getTypeID()?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77768/new/

https://reviews.llvm.org/D77768