[PATCH] D77764: [mlir] Mark ClassID::getID as LLVM_EXTERNAL_VISIBILITY to ensure only one version exists

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 17:24:35 PDT 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG21605a120774: [mlir] Mark ClassID::getID as LLVM_EXTERNAL_VISIBILITY to ensure only oneā€¦ (authored by rriddle).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77764/new/

https://reviews.llvm.org/D77764

Files:
  mlir/include/mlir/Support/STLExtras.h


Index: mlir/include/mlir/Support/STLExtras.h
===================================================================
--- mlir/include/mlir/Support/STLExtras.h
+++ mlir/include/mlir/Support/STLExtras.h
@@ -93,11 +93,13 @@
 /// Note: We specify an explicit alignment here to allow use with PointerIntPair
 /// and other utilities/data structures that require a known pointer alignment.
 struct alignas(8) ClassID {
-  template <typename T> static ClassID *getID() {
+  template <typename T>
+  LLVM_EXTERNAL_VISIBILITY static ClassID *getID() {
     static ClassID id;
     return &id;
   }
-  template <template <typename T> class Trait> static ClassID *getID() {
+  template <template <typename T> class Trait>
+  LLVM_EXTERNAL_VISIBILITY static ClassID *getID() {
     static ClassID id;
     return &id;
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77764.256149.patch
Type: text/x-patch
Size: 807 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200409/e0fff2eb/attachment-0001.bin>


More information about the llvm-commits mailing list