[PATCH] D77708: [lit] Improve naming of test result categories

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 17:24:29 PDT 2020


jdenny added a comment.

In D77708#1970685 <https://reviews.llvm.org/D77708#1970685>, @jdenny wrote:

> In D77708#1970510 <https://reviews.llvm.org/D77708#1970510>, @yln wrote:
>
> > For devs who need to care the "normal" is short and the "odd" is long and ugly to draw attention:
> >
> >   Expectedly Failing:   1
> >   Unexpectedly Passing: 1
> >
>
>
> I'm not sure what you're saying here.  Could you explain a bit more?


Ah, nevermind.  After a second look, I got your meaning.

People can certainly learn that, by Passes, lit doesn't really mean all passes.  I'd prefer less ambiguous terminology, but I'm in the minority so far, and it's not a big deal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77708/new/

https://reviews.llvm.org/D77708





More information about the llvm-commits mailing list