[PATCH] D77736: [DSE] Lift post-dominance for objs not accessible in caller.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/memset-missing-debugloc.ll:39
   store i64 2, i64* %5, align 8, !dbg !16
-  %call = call i32 @_Z1av(), !dbg !17
+  %call = call i32 @_Z1av([5 x i64]* %b), !dbg !17
   %tobool = icmp ne i32 %call, 0, !dbg !17
----------------
asbirlea wrote:
> I don't fully understand the need for this test change, could you please clarify?
They are not required for this patch. I think they are supposed to be part of a different patch ( eliminating stores that are never read) and slipped in during a rebase.

 Without changes, the function in the file never reads the stores/memset to the alloca and they can be completely removed. But that's not related to the patch and I've removed those changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77736/new/

https://reviews.llvm.org/D77736