[PATCH] D77276: Clean up usages of asserting vector getters in Type

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 16:19:31 PDT 2020


ctetreau marked an inline comment as done.
ctetreau added inline comments.


================
Comment at: llvm/lib/IR/ConstantFold.cpp:748
 
+  auto *V1VTy = cast<VectorType>(V1->getType());
+
----------------
efriedma wrote:
> ConstantFoldSelectInstruction can take non-vector inputs.  This should cause test failures.  (Somehow I thought you fixed this in an earlier revision, but I could be mistaken.)
I'll fix it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77276/new/

https://reviews.llvm.org/D77276





More information about the llvm-commits mailing list