[PATCH] D77695: [SVE] Remove isScalable from Bitcode

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 15:46:24 PDT 2020


tejohnson added a comment.

In D77695#1970465 <https://reviews.llvm.org/D77695#1970465>, @ctetreau wrote:

> In D77695#1970457 <https://reviews.llvm.org/D77695#1970457>, @tejohnson wrote:
>
> > I'm missing some context. I can't find ScalableVectorType, is this dependent on a pending patch?
>
>
> I'm working on a big refactor the Type class hierachry, adding a FixedVectorType and ScalableVectorType.
>
> This is part of that. I'm splitting it up as much as possible. As I mentioned above, this won't build until D77587 <https://reviews.llvm.org/D77587> is merged.


Ah ok. For future reference it's typical to add a "Depends on D77587 <https://reviews.llvm.org/D77587>" line to the description to indicate this. This will also automatically add it as the parent version in Phabricator. You can do it now after the fact in Phabricator. See the top right and select "Edit Related Revisions" and add D77587 <https://reviews.llvm.org/D77587> as the parent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77695/new/

https://reviews.llvm.org/D77695





More information about the llvm-commits mailing list