[PATCH] D77655: [VPlan] Add & use VPValue operands for VPWidenCallRecipe (NFC).

[Gil Rapaport via Phabricator via llvm-commits]

gilr accepted this revision.
gilr added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:6935
+
+  return new VPWidenCallRecipe(*CI, Values);
 }
----------------
fhahn wrote:
> gilr wrote:
> > Have VPWidenCallRecipe() take an iterator_range instead of ArrayRef, saving the temporary SmallVector?
> The way the types stack up with iterator_range and map_iterator we would need to add template version of the VPWidenCallRecipe and VPUser constructors. I think that would make sense, to provide more convenience to users of those classes. I;ve updated the patch. What do you think?
LGTM, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanValue.h:25
 #include "llvm/ADT/SmallVector.h"
+#include "llvm/ADT/iterator_range.h"
 #include "llvm/IR/Value.h"
----------------
Lexical order


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77655/new/

https://reviews.llvm.org/D77655